Remove unnecessary use of aria-hidden in the character count
#2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `govuk-character-count__message--disabled` hides the message using `visibility: hidden`, so there is no need to also use the `aria-hidden` attribute. > If an interactive element is hidden using display:none or visibility:hidden (either on the element itself, or any of the element's ancestors), it won't be focusable, and it will also be removed from the accessibility tree. This makes the addition of aria-hidden="true" or explicitly setting tabindex="-1" unnecessary. > > https://www.w3.org/TR/using-aria/#4thrule
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2479
|
Everything I've read suggests that nothing will be announced by the live region (as intended) when the element is hidden using |
|
Closing this as this needs further investigation… from testing there are a few issues with the current implementation that should be addressed first:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
govuk-character-count__message--disabledclass hides the message usingvisibility: hidden, so there is no need to also use thearia-hiddenattribute.